Conversation
|
@codex review |
There was a problem hiding this comment.
Pull request overview
This PR modernizes the codebase by updating dependencies and applying linting improvements with Biome. The changes replace Prettier with Biome for code formatting, update TypeScript imports to use type modifiers, and standardize code style. A notable fix addresses an incorrect property name in Quest.ts, changing from id to questId to match type definitions.
- Updated all dependencies including Node.js requirement (>=21.0.0), TypeScript (^5.9.3), and Jest (^30.2.0)
- Replaced Prettier with Biome for linting and formatting
- Corrected property name from
idtoquestIdin Quest.ts to match type definitions
Reviewed changes
Copilot reviewed 23 out of 24 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| package.json | Updated dependencies, replaced Prettier with Biome, increased Node.js requirement to >=21.0.0, removed node-fetch dependency |
| biome.json | Added Biome configuration with formatting and linting rules |
| .prettierignore | Removed Prettier configuration file |
| src/index.ts | Reorganized imports and reformatted Smeargle moves data |
| src/typings/*.ts | Added type modifiers to import statements |
| src/classes/Quest.ts | Fixed property name from id to questId and improved type annotations |
| src/classes/*.ts | Added type modifiers to imports and applied linting fixes |
| src/base.ts | Added type modifier to import statement |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Mygod
left a comment
Mygod
left a comment
There was a problem hiding this comment.
Fixed some small things. LGTM.
| const values = Object.entries( | ||
| object.data.pokemonExtendedSettings.sizeSettings, | ||
| ).map(([name, value]) => ({ name, value })) | ||
| ).map(([name, value]) => ({ name, value: Number(value) })) |
There was a problem hiding this comment.
@TurtIeSocks this writes now disablePokedexRecordDisplayForForms in SizeSettings as number, instead of Boolean
I will try to fix: #126 , but WIP
3 participants
Only change that might affect things was fixing the ID thing in
Quest.ts. It was adding anidproperty but according to the types, it should bequestId?